diff --git a/src/main/java/com/ffii/tsms/modules/data/service/StaffsService.kt b/src/main/java/com/ffii/tsms/modules/data/service/StaffsService.kt index 6772c61..55fc1bd 100644 --- a/src/main/java/com/ffii/tsms/modules/data/service/StaffsService.kt +++ b/src/main/java/com/ffii/tsms/modules/data/service/StaffsService.kt @@ -290,10 +290,20 @@ open class StaffsService( userRepository.save(user) } // salaryEffectiveService.saveSalaryEffective(staff.id!!, salary.salaryPoint.toLong()) - salaryEffectiveService.updateSalaryEffective(staff.id!!, req.salaryEffectiveInfo?.sortedBy { it.date }, req.delSalaryEffectiveInfo) - teamLogService.editTeamLog(req.teamHistory, req.delTeamHistory) - gradeLogService.editGradeLog(req.gradeHistory, req.delGradeHistory) - positionLogService.editPositionLog(req.positionHistory, req.delPositionHistory) + if ( + !req.teamHistory.isNullOrEmpty() && + !req.delTeamHistory.isNullOrEmpty() && + !req.gradeHistory.isNullOrEmpty() && + !req.delGradeHistory.isNullOrEmpty() && + !req.positionHistory.isNullOrEmpty() && + !req.delPositionHistory.isNullOrEmpty() + ) { + salaryEffectiveService.updateSalaryEffective(staff.id!!, req.salaryEffectiveInfo?.sortedBy { it.date }, req.delSalaryEffectiveInfo) + teamLogService.editTeamLog(req.teamHistory, req.delTeamHistory) + gradeLogService.editGradeLog(req.gradeHistory, req.delGradeHistory) + positionLogService.editPositionLog(req.positionHistory, req.delPositionHistory) + + } return staffRepository.save(staff) } diff --git a/src/main/java/com/ffii/tsms/modules/data/web/models/NewStaffRequest.kt b/src/main/java/com/ffii/tsms/modules/data/web/models/NewStaffRequest.kt index 8f64142..e923a38 100644 --- a/src/main/java/com/ffii/tsms/modules/data/web/models/NewStaffRequest.kt +++ b/src/main/java/com/ffii/tsms/modules/data/web/models/NewStaffRequest.kt @@ -38,13 +38,13 @@ data class NewStaffRequest( val departReason: String?, val remark: String?, val salaryEffectiveInfo: List?, - val teamHistory: List, - val gradeHistory: List, - val positionHistory: List, - val delSalaryEffectiveInfo: List, - val delTeamHistory: List, - val delGradeHistory: List, - val delPositionHistory: List, + val teamHistory: List?, + val gradeHistory: List?, + val positionHistory: List?, + val delSalaryEffectiveInfo: List?, + val delTeamHistory: List?, + val delGradeHistory: List?, + val delPositionHistory: List?, ) data class SalaryEffectiveInfo(