From 600f5d801ab5a59638ef7168935e84fad53ee7d9 Mon Sep 17 00:00:00 2001
From: "MSI\\derek" <abc@gmail.com>
Date: Sat, 2 Aug 2025 16:17:36 +0800
Subject: [PATCH] update

---
 .../modules/purchaseOrder/service/PurchaseOrderService.kt     | 4 +++-
 .../fpsms/modules/stock/service/SuggestedPickLotService.kt    | 4 ++--
 2 files changed, 5 insertions(+), 3 deletions(-)

diff --git a/src/main/java/com/ffii/fpsms/modules/purchaseOrder/service/PurchaseOrderService.kt b/src/main/java/com/ffii/fpsms/modules/purchaseOrder/service/PurchaseOrderService.kt
index d64983f..8368108 100644
--- a/src/main/java/com/ffii/fpsms/modules/purchaseOrder/service/PurchaseOrderService.kt
+++ b/src/main/java/com/ffii/fpsms/modules/purchaseOrder/service/PurchaseOrderService.kt
@@ -245,7 +245,9 @@ open class PurchaseOrderService(
 
         val po = purchaseOrderRepository.findById(id).orElseThrow()
         if (unfinishedLines.isEmpty()) {
-            val stockInLines = stockInLineRepository.findAllByPurchaseOrderIdAndDeletedFalse(po.id).orElseThrow()
+            val stockInLines = stockInLineRepository.findAllByPurchaseOrderIdAndDeletedFalse(po.id!!).orElseThrow().filter {
+                it.status == StockInLineStatus.COMPLETE.status
+            }
             po.apply {
                 status = PurchaseOrderStatus.COMPLETED
             }
diff --git a/src/main/java/com/ffii/fpsms/modules/stock/service/SuggestedPickLotService.kt b/src/main/java/com/ffii/fpsms/modules/stock/service/SuggestedPickLotService.kt
index f8f5611..3c27478 100644
--- a/src/main/java/com/ffii/fpsms/modules/stock/service/SuggestedPickLotService.kt
+++ b/src/main/java/com/ffii/fpsms/modules/stock/service/SuggestedPickLotService.kt
@@ -71,7 +71,7 @@ open class SuggestedPickLotService(
         val suggestedList: MutableList<SuggestedPickLot> = mutableListOf()
         val holdQtyMap: MutableMap<Long?, BigDecimal?> = request.holdQtyMap
 
-        // get current inventory lot line qty & grouped by item Id
+        // get current inventory lot line qty & grouped by item id
         val availableInventoryLotLines = inventoryLotLineService
             .allInventoryLotLinesByItemIdIn(itemIds)
             .filter { it.status == InventoryLotLineStatus.AVAILABLE.value }
@@ -182,6 +182,6 @@ open class SuggestedPickLotService(
     }
 
     open fun saveAll(request: List<SuggestedPickLot>): List<SuggestedPickLot> {
-        return suggestedPickLotRepository.saveAll(request)
+        return suggestedPickLotRepository.saveAllAndFlush(request)
     }
 }
\ No newline at end of file