From 1a3b29e43eaddebd182a6de83f1322aabc2a3d73 Mon Sep 17 00:00:00 2001 From: "MSI\\derek" Date: Sat, 2 Aug 2025 16:32:16 +0800 Subject: [PATCH] update --- .../PickOrderDetail/PickOrderDetail.tsx | 37 +++++-------------- src/components/PoDetail/PoQcStockInModal.tsx | 6 +-- 2 files changed, 13 insertions(+), 30 deletions(-) diff --git a/src/components/PickOrderDetail/PickOrderDetail.tsx b/src/components/PickOrderDetail/PickOrderDetail.tsx index 64b7b80..1b9543c 100644 --- a/src/components/PickOrderDetail/PickOrderDetail.tsx +++ b/src/components/PickOrderDetail/PickOrderDetail.tsx @@ -242,7 +242,7 @@ const PickOrderDetail: React.FC = ({ consoCode, qc }) => { pickOrderLineTable: false, })); }, - [fetchPickOrderLineClient, consoCode], + [consoCode], ); const [stockOutLine, setStockOutLine] = useState([]); @@ -314,7 +314,7 @@ const PickOrderDetail: React.FC = ({ consoCode, qc }) => { // openStartModal(); }, 500); }, - [createStockOutLine], + [consoCode], ); useEffect(() => { @@ -337,7 +337,7 @@ const PickOrderDetail: React.FC = ({ consoCode, qc }) => { setBtnIsLoading(false); }, 200); }, - [], + [openApprovalModal], ); const handleLotChange = useCallback( @@ -380,7 +380,7 @@ const PickOrderDetail: React.FC = ({ consoCode, qc }) => { setBtnIsLoading(false); }, 200); }, - [], + [getQcResult, openQcModal], ); const stockOutLineColumns = useMemo( @@ -523,7 +523,7 @@ const PickOrderDetail: React.FC = ({ consoCode, qc }) => { }, }, ], - [stockOutLineStatusMap, handleStart, handleDelete], + [t, handleStart, handleApproval, handleLotChange, handleComplete, handleDelete], ); const fetchStockOutLine = useCallback( @@ -596,15 +596,7 @@ const PickOrderDetail: React.FC = ({ consoCode, qc }) => { // getConsoStatus() } if (selectedRow.length > 0) fetchStockOutLine(solCriteriaArgs, selectedRow); - }, [ - qcOpen, - approvalOpen, - solCriteriaArgs, - selectedRow, - triggerRefetch, - polCriteriaArgs, - getConsoStatus, - ]); + }, [qcOpen, approvalOpen, solCriteriaArgs, selectedRow, triggerRefetch, polCriteriaArgs, getConsoStatus, fetchStockOutLine, fetchPickOrderLine]); const getLotDetail = useCallback( async (stockInLineId: number): Promise => { @@ -613,18 +605,9 @@ const PickOrderDetail: React.FC = ({ consoCode, qc }) => { console.log(res); return res; }, - [fetchLotDetail], + [], ); - const getQcResult = useCallback( - async (stockOutLineId: number): Promise => { - const res = await fetchPickOrderQcResult(stockOutLineId); - console.log("res"); - console.log(res); - return res; - }, - [fetchPickOrderQcResult], - ); const [isOpenScanner, setOpenScanner] = useState(false); const onOpenScanner = useCallback(() => { @@ -638,7 +621,7 @@ const PickOrderDetail: React.FC = ({ consoCode, qc }) => { } else if (!isOpenScanner && scanner.isScanning) { scanner.stopScan(); } - }, [isOpenScanner]); + }, [isOpenScanner, scanner]); const homemade_Qrcode = { // stockInLineId: 156, // eggs @@ -698,7 +681,7 @@ const PickOrderDetail: React.FC = ({ consoCode, qc }) => { } return Object.keys(error).length > 0 ? error : undefined; }, - [currPol], + [currPol?.qty, t], ); const processRowUpdate = useCallback( @@ -728,7 +711,7 @@ const PickOrderDetail: React.FC = ({ consoCode, qc }) => { setStockOutLine(newEntries as StockOutLine[]); return rowToSave; }, - [stockOutLine, validation], + [getRowId, stockOutLine, validation], ); const onProcessRowUpdateError = useCallback( diff --git a/src/components/PoDetail/PoQcStockInModal.tsx b/src/components/PoDetail/PoQcStockInModal.tsx index e5073b8..49c0466 100644 --- a/src/components/PoDetail/PoQcStockInModal.tsx +++ b/src/components/PoDetail/PoQcStockInModal.tsx @@ -164,7 +164,7 @@ const PoQcStockInModal: React.FC = ({ const checkStockIn = useCallback( (data: ModalFormInput): boolean => { let hasErrors = false; - if (!isFinite(accQty) || accQty! <= 0 ) { + if (accQty! <= 0 ) { formProps.setError("acceptedQty", { message: `${t("Accepted qty must greater than")} ${ 0 @@ -354,7 +354,7 @@ const PoQcStockInModal: React.FC = ({ console.log(e); } }, - [t, itemDetail, checkStockIn, checkPutaway], + [setIsUploading, formProps, errors, itemDetail, type, params, checkStockIn, checkPutaway, t, setEntries, setStockInLine, setItemDetail, closeHandler], ); const printQrcode = useCallback(async () => { @@ -369,7 +369,7 @@ const PoQcStockInModal: React.FC = ({ } setBtnIsLoading(false); setIsUploading(false); - }, [itemDetail, fetchPoQrcode, downloadFile]); + }, [setIsUploading, itemDetail.id]); const renderSubmitButton = useMemo((): boolean => { if (itemDetail) {